GitHub Community
Allow users to set "Hide whitespace changes" by default #5486
-
|
This is a feature request that exists for 3 years (https://github.community/t/feature-request-option-to-always-hide-whitespace-changes-when-viewing-diffs/1896) and would be a very nice addition for GitHub. The problemMany users want to by default always "Hide whitespace changes" on Git PR diffs or GitHub code diffs in general. The solution
|
Beta Was this translation helpful? Give feedback.
Replies: 23 comments 31 replies
-
|
If not as a setting, then as part of a GET param or a cookie. |
Beta Was this translation helpful? Give feedback.
-
|
GET param already exists. Add |
Beta Was this translation helpful? Give feedback.
-
|
that works @zeitwidrig but you have to add it every time and it seems like it gets cleared when you navigate to another GH page |
Beta Was this translation helpful? Give feedback.
-
|
Sometimes I move code and the PR that I make seems very complex, but when you use "Hide whitespace changes" you can easliy realize that one change a couple of lines. I would love to be able to configure this for each PR differently. |
Beta Was this translation helpful? Give feedback.
-
|
I would claim that it would be better to have individual settings for file types, for the project. As e.g. indentation is important for some file types. |
Beta Was this translation helpful? Give feedback.
-
|
This is partially addressed by a feature we shipped a few weeks ago: https://github.blog/changelog/2021-10-14-hiding-whitespace-is-now-remembered-for-each-pull-request/ GitHub now remembers "hide whitespace" for you on the pull requests you enable it on. We explored other options including a user-level setting (and we may reassess in the future), but decided the right first step was to remember it for each pull request. |
Beta Was this translation helpful? Give feedback.
-
|
This is not an answer. |
Beta Was this translation helpful? Give feedback.
-
|
Kinda crazy this isn't a setting I can choose FOR ALL PRs. Also insane that this would be considered an answer. The more I do stuff on Github the more I miss Gitlab... I sure miss all the options and configurations I had there. It's so annoying to have to enable this option every single time I visit some random PR for either work or some open source project. |
Beta Was this translation helpful? Give feedback.
-
|
Dear @willsmythe , the common issue for small PRs are not that they are revisited many times by each user. It would be SO much better if the repo got a common flag reflecting the code style used in the project, or more advanced a set of flags matching the file-types. e.g. we DO want yaml-files to care about indentation, but we do not care about whitespaces in e.g. C# files. The saved flag will help for huge PRs that take a long time and many re-visits to review, but I would claim this a special case, as the huge PR often could have benefitted from being broken down to several smaller in the first place. I know this is not always possible though, and for these special cases the saved flag can help. But it is not an answer to the suggestion ...And if huge, it is also likely to contain multiple file types, where the relevant setting of the flag might not be the same... |
Beta Was this translation helpful? Give feedback.
-
|
I agree that per-user-and-repo would be an MVP on this. We already have the ability to store a preference for which email should be used for each repo. Can we not also add a flag for whitespace to that relationship? |
Beta Was this translation helpful? Give feedback.
-
|
@willsmythe @michellemerrill It's great that a forward step has been taken, but it is not equivalent to the feature being requested here, so should this question really be marked as answered and shipped? This is still a valid outstanding feature request. |
Beta Was this translation helpful? Give feedback.
-
|
Any updates? |
Beta Was this translation helpful? Give feedback.
-
|
https://github.blog/changelog/2021-10-14-hiding-whitespace-is-now-remembered-for-each-pull-request/ |
Beta Was this translation helpful? Give feedback.
-
|
Hi @willsmythe, could you remove the |
Beta Was this translation helpful? Give feedback.
-
|
It says @michellemerrill marked it as the answer; maybe they could remove that... |
Beta Was this translation helpful? Give feedback.
-
|
I'm using https://chrome.google.com/webstore/detail/github-whitespace/fnpkdafamnbjoldglihkjjdicofghccm as a temporary fix for that. |
Beta Was this translation helpful? Give feedback.
-
|
The only problem is it doesn't let you view diffs with white space enabled anymore. |
Beta Was this translation helpful? Give feedback.
-
|
https://chrome.google.com/webstore/detail/git-well-soon/ehpeaofieafibmhiagianfjjblpnmbdo allows a user override to view whitespace. Also works for github enterprise |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the link! However it won't work for people whose companies block third-party extensions. |
Beta Was this translation helpful? Give feedback.
-
|
For the love of all that is good, thank you for that extension link! I've wasted so much time sorting through PRs when I forget to check "hide whitespace"... Please please please GitHub, revisit this as a user setting! |
Beta Was this translation helpful? Give feedback.
-
|
This seems to work for Firefox.
https://addons.mozilla.org/en-US/firefox/addon/github-whitespace-disabler/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
Omar
…On Wed, Apr 20, 2022 at 4:44 PM, Vilen Topchii ***@***.***> wrote:
I'm using https://chrome.google.com/webstore/detail/github-whitespace/
fnpkdafamnbjoldglihkjjdicofghccm as a temporary fix for that.
—
Reply to this email directly, view it on GitHub
<#5486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAONU3UK7DRCXK5HLOGOPFTVF6YXNANCNFSM5DQBTCNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I would also prefer this setting exist at a per-user level. It is almost never useful to see whitespace changes and I have to turn this off consistently. |
Beta Was this translation helpful? Give feedback.
-
|
Voicing support for a user-level setting to keep Hide Whitespace... it's nice to stay on the PR, sure, but working in a project where whitespace doesn't matter, and is also handled via Prettier/Eslint, this is really annoying to have to toggle it for every single PR. Any are acceptable options in my mind:
|
Beta Was this translation helpful? Give feedback.
-
|
My chrome extension solves for this problem until github decides to support this function: https://chrome.google.com/webstore/detail/git-well-soon/ehpeaofieafibmhiagianfjjblpnmbdo |
Beta Was this translation helpful? Give feedback.
-
|
Note to any employees at GitHub that see this comment... This is not a fix, having to download a random extension is a security risk - not trying to accuse the developer, just is a concern. |
Beta Was this translation helpful? Give feedback.
-
|
The permissions requested are too broad on this extension. Definitely not installing as it asks for permissions to read all websites, as well as browsing history. |
Beta Was this translation helpful? Give feedback.
-
|
@willsmythe are you aware of the negative feedback of the proposed solution? JFYI |
Beta Was this translation helpful? Give feedback.
-
|
Would love this to be a user setting. |
Beta Was this translation helpful? Give feedback.
-
|
My team is still interested in this feature, and the "answer" doesn't address the issue. |
Beta Was this translation helpful? Give feedback.
-
|
This would honestly be so helpful and convenient. And as the marked comment states with the world "partially", this isn't, in fact, resolved. |
Beta Was this translation helpful? Give feedback.
-
|
@willsmythe - not sure why this is marked as |
Beta Was this translation helpful? Give feedback.
-
|
Should just make a new issue/discussion, they’re probably just ignoring this since it says it’s resolved |
Beta Was this translation helpful? Give feedback.
-
|
I can't believe it's 2023 and this still isn't possible. Please implement it. |
Beta Was this translation helpful? Give feedback.
-
|
This is a problem especially hitting C# (and similar) when using the quite common 'convention' of moving the If they, when syncing the two, gave a sole '{' (and '}' ) with any indentation the same (low) synchronisation weight, it will be much more likely to get the syncing right, and the urgent need for the feature they seem to refuse to implement would be almost gone. In a more advanced version it could (for syncing purposes) consider a set of pure punctuation chars (braces, parentheses, comma... ) with any indentation as something logically 'belonging' to the and of the previous line. It would make it much more likely to get the syncing right. Obviously it shall be displayed as in the file, I'm merely talking about the logic for syncing. |
Beta Was this translation helpful? Give feedback.
-
|
remember-the-setting-when-revisiting isn't a solution. Please allow a default 'hide whitespace' setting. If hide-reveal whitespace is already possible, why is adding a config setting hard? |
Beta Was this translation helpful? Give feedback.
-
|
I assume because it requires changes to the account page to add that option and there currently isn't a good section for it, it would probably be something like "Your Code Review Preferences" but there isn't such a section yet. And it has to be applied to each PR you're looking at. And potentially be overwritten by the Pr-specific settings. So, not trivial, and also probably not a big enough product priority given that we can already set it on a PR manually. @willsmythe this would be a good one to bundle in a "Your Code Review Preferences" page when there is enough preferences for that account page to make sense. Any idea if this is in the roadmap? |
Beta Was this translation helpful? Give feedback.
-
|
Adding a toggle option is trivial, and GitHub isn't known for consistent or amazing UI design, so that shouldn't stop them. But it wouldn't suprise me if you're right that they can't figure out how to make this fit easily... |
Beta Was this translation helpful? Give feedback.
-
|
Make it exactly the same as split or unified view. That persists from PR to PR and it is already next to the per PR whitespace toggle. All that would change is to add whatever persistence they already use for the view to the whitespace toggle. |
Beta Was this translation helpful? Give feedback.
-
|
I must agree. This seems like a no-brainer to make into a user setting. Please do so! |
Beta Was this translation helpful? Give feedback.
-
|
A new discussion was opened on this topic: https://github.com/orgs/community/discussions/65597 |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
thanks |
Beta Was this translation helpful? Give feedback.
and others
This is partially addressed by a feature we shipped a few weeks ago: https://github.blog/changelog/2021-10-14-hiding-whitespace-is-now-remembered-for-each-pull-request/
GitHub now remembers "hide whitespace" for you on the pull requests you enable it on.
We explored other options including a user-level setting (and we may reassess in the future), but decided the right first step was to remember it for each pull request.